[ML] Convert Explorer Influencers List to EUI/React #18773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
v7.0.0
v6.4.0
:ml
Feature:ml-results
|
Pinging @elastic/ml-ui |
walterra
reviewed
May 3, 2018
| const totalScoreLabel = totalScore !== 0 ? totalScore : '< 1'; | ||
|
|
||
| // Ensure the bar has some width for 0 scores. | ||
| const barScore = maxScore !== 0 ? maxScore : 1; |
There was a problem hiding this comment.
nitpick: styleguide suggests to always use parentheses for conditionals, the ternary examples also use parentheses.
walterra
reviewed
May 3, 2018
|
|
||
| } | ||
| module.directive('mlInfluencersListReact', function ($injector) { |
There was a problem hiding this comment.
mlInfluencersListReact should stay mlInfluencersList.
walterra
reviewed
May 3, 2018
| index-pattern-id="indexPatternId" | ||
| tooltip-placement="right"> | ||
| </ml-influencers-list> | ||
| <ml-influencers-list-react |
There was a problem hiding this comment.
ml-influencers-list-react should stay ml-influencers-list.
💚 Build Succeeded |
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
May 4, 2018
* [ML] Convert Explorer Influencers List to EUI/React * [ML] Remove unused abbreviate_whole_number Angular filter * [ML] Convert React Influencers List to stateless function
|
Addresses Influencers List item on #18374 |
peteharverson
added a commit
that referenced
this pull request
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the Influencers List component, used in the Anomaly Explorer, from Angular to EUI / React.
Also includes some styling edits to clean up the look of the section titles, bars and total score indicators.
Previous Angular based component:
EUI / React component:
