Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] Add model parameter to token telemetry #187783

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Jul 8, 2024

Summary

Adds the model parameter to GenAI token tracking telemetry events if defaultModel is a property on the connector config

Screenshot 2024-07-08 at 11 28 38 AM

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI v8.15.0 v8.16.0 labels Jul 8, 2024
@stephmilovic stephmilovic requested a review from a team as a code owner July 8, 2024 17:30
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@stephmilovic stephmilovic merged commit 2b5ff77 into elastic:main Jul 8, 2024
30 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 8, 2024
…87783) (#187793)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Security solution] Add model parameter to token telemetry
(#187783)](#187783)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2024-07-08T18:53:25Z","message":"[Security
solution] Add model parameter to token telemetry
(#187783)","sha":"2b5ff7709515836b6ce91d6ce28ed3316f78d930","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Security
Generative AI","v8.15.0","v8.16.0"],"title":"[Security solution] Add
model parameter to token
telemetry","number":187783,"url":"#187783
solution] Add model parameter to token telemetry
(#187783)","sha":"2b5ff7709515836b6ce91d6ce28ed3316f78d930"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"#187783
solution] Add model parameter to token telemetry
(#187783)","sha":"2b5ff7709515836b6ce91d6ce28ed3316f78d930"}}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
yansavitski pushed a commit to yansavitski/kibana that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants