Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] temporarily exclude aggs from inline docs script #188473

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

drewdaemon
Copy link
Contributor

Summary

As ES has rolled out partial support for generating agg function definitions and documentation, they have become mixed into the existing scalar function documentation section. This PR excludes them for now. Once elastic/elasticsearch#107219 is complete, we will unskip them and turn on full automation!

@drewdaemon drewdaemon added Feature:ES|QL Team:ESQL ES|QL related features in Kibana labels Jul 16, 2024
@drewdaemon
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 183.4KB 181.5KB -2.0KB

@drewdaemon drewdaemon marked this pull request as ready for review July 16, 2024 22:08
@drewdaemon drewdaemon requested a review from a team as a code owner July 16, 2024 22:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@drewdaemon drewdaemon added the release_note:skip Skip the PR/issue when compiling release notes label Jul 16, 2024
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Drew, thanx

@jbudz jbudz merged commit dce0ba1 into elastic:main Jul 17, 2024
27 of 28 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants