Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Only allow to send requests that have a valid method #189515

Merged

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Jul 30, 2024

Fixes https://github.com//elastic/kibana/issues/186768

Summary

This PR changes the monaco editor behaviour to only send requests for valid methods, otherwise a toast will be shown.

Screenshot 2024-07-31 at 12 04 18

@sabarasaba sabarasaba added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.16.0 labels Jul 30, 2024
@sabarasaba sabarasaba self-assigned this Jul 30, 2024
@sabarasaba
Copy link
Member Author

/ci

@sabarasaba sabarasaba marked this pull request as ready for review July 31, 2024 12:52
@sabarasaba sabarasaba requested a review from a team as a code owner July 31, 2024 12:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this bug, @sabarasaba!
Verified locally and the only minor thing I noticed with multiple requests: if some are invalid and some are okay, the good ones are sent and the invalid ones are filtered out silently. That could be potentially confusing to the user, but I think that might need to be addressed together with https://github.com//elastic/kibana/issues/186773 and #189366

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba
Copy link
Member Author

Thanks a lot for fixing this bug, @sabarasaba! Verified locally and the only minor thing I noticed with multiple requests: if some are invalid and some are okay, the good ones are sent and the invalid ones are filtered out silently. That could be potentially confusing to the user, but I think that might need to be addressed together with https://github.com//elastic/kibana/issues/186773 and #189366

Ohh nice catch! Yeah sounds good lets tackle that scenario with the other issue then.

@sabarasaba sabarasaba enabled auto-merge (squash) August 1, 2024 11:27
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 457.8KB 458.0KB +205.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba merged commit cca1a3c into elastic:main Aug 1, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants