-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Only allow to send requests that have a valid method #189515
[Console] Only allow to send requests that have a valid method #189515
Conversation
/ci |
Pinging @elastic/kibana-management (Team:Kibana Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing this bug, @sabarasaba!
Verified locally and the only minor thing I noticed with multiple requests: if some are invalid and some are okay, the good ones are sent and the invalid ones are filtered out silently. That could be potentially confusing to the user, but I think that might need to be addressed together with https://github.com//elastic/kibana/issues/186773 and #189366
@elasticmachine merge upstream |
Ohh nice catch! Yeah sounds good lets tackle that scenario with the other issue then. |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
Fixes https://github.com//elastic/kibana/issues/186768
Summary
This PR changes the monaco editor behaviour to only send requests for valid methods, otherwise a toast will be shown.