[ML] Migrate ml-info-icon to EUI/React #19003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
review
v7.0.0
v6.4.0
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
peteharverson
approved these changes
May 11, 2018
💚 Build Succeeded |
jgowdyelastic
approved these changes
May 15, 2018
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| import './tooltip_directive'; |
There was a problem hiding this comment.
new line missing here.
not sure if this is a bad thing as there is no lint rule for it. but github flags it up.
"files.insertFinalNewline": true in vscode will do this automatically.
The same for x-pack/plugins/ml/public/components/tooltip/tooltip_directive.js
💔 Build Failed |
88 tasks
|
jenkins test this |
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
May 17, 2018
This replaces the angular based tooltip used in the ml-info-icon directive with one based on React/EuiTooltip. It supports transclusion and rendering of angular template snippets inside the tooltip. Because the DOM structure of the EuiTooltips and the angular/bootstrap tooltips is quite different there is a bit more code involved to achieve this, but the result is that for this we don't have to change the markup in the original angular templates where ml-info-icon is used.
walterra
added a commit
that referenced
this pull request
May 17, 2018
This replaces the angular based tooltip used in the ml-info-icon directive with one based on React/EuiTooltip. It supports transclusion and rendering of angular template snippets inside the tooltip. Because the DOM structure of the EuiTooltips and the angular/bootstrap tooltips is quite different there is a bit more code involved to achieve this, but the result is that for this we don't have to change the markup in the original angular templates where ml-info-icon is used.
walterra
changed the title
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the angular based tooltip used in the
ml-info-icondirective with one based on React/EuiTooltip. It supports transclusion and rendering of angular template snippets inside the tooltip. Because the DOM structure of the EuiTooltips and the angular/bootstrap tooltips is quite different there is a bit more code involved to achieve this, but the result is that for this we don't have to change the markup in the original angular templates whereml-info-iconis used.This doesn't use
ngReactto have more detailed control on how to work with the transclusion of angular template snippets as well as skip any two-way-binding which isn't necessary for these type of tooltips.Follow-up PRs will use this as a basis to replace other angular based tooltips.
Part of #18374.