[ML] Migrate field-type-icon to EUI/React. #19159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
peteharverson
approved these changes
May 17, 2018
| let iconClass = ''; | ||
| let iconChar = ''; | ||
|
|
||
| switch (type) { |
There was a problem hiding this comment.
We should migrate these Font Awesome icons to EUI icons I think. There are suitable replacements for most of these:
- fa-adjust - invert
- fa-clock-o - clock
- hash symbol - number
- fa-file-text-o - document (although would be nice to have one for a text style document)
I can't find any suitable replacements for
- fa-globe
- fa-laptop
You should raise an issue in the eui repo for the icons we need added.
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
May 17, 2018
Migrates the field-type-icon directive to use EUI/React. Instead of the angular/bootstrap tooltip attribute on the directive's tag, there's now an option tooltip-enabled which when true wraps the component inside EuiToolTip.
88 tasks
walterra
added a commit
that referenced
this pull request
May 17, 2018
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the
field-type-icondirective to use EUI/React.Instead of the angular/bootstrap
tooltipattribute on the directive's tag, there's now an optiontooltip-enabledwhich whentruewraps the component insideEuiToolTip.Part of #18374.