Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] Clean up dashboard listing page #19657

Merged
merged 11 commits into from
Jun 13, 2018
Merged

Conversation

snide
Copy link
Contributor

@snide snide commented Jun 4, 2018

@snide
Copy link
Contributor Author

snide commented Jun 4, 2018

@nreese There's a visual hitch where the table loads, then the empty state. Assume this is the way state is being loaded. Not needed now, but it would be nice to do that sort of check before the view is loaded so it removes the "flash".

aka...

  1. Loading...
  2. Show table or empty state...

rather than...

  1. show table...
  2. show empty state if empty

@snide
Copy link
Contributor Author

snide commented Jun 4, 2018

@gchaps Yell if you have any better text for that empty screen. Care on that second graph, I'd love for it not to wrap.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Jun 4, 2018

jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@gchaps
Copy link
Contributor

gchaps commented Jun 4, 2018

@snide Here are some suggestions for the empty state:

Create your first dashboard

You can combine data views from any Kibana app into one dashboard and see everything in one place.

New to Kibana?  Install our sample data and test drive the dashboards.

Create dashboard


For the one-liner (no wrapping) in the graph:

Analyze sample flight data for 5 airlines

@elasticmachine
Copy link
Contributor

💔 Build Failed

You can combine data views from any Kibana app into one dashboard and see everything in one place.
</p>
<p>
New to Kibana? <EuiLink href="#/home/tutorial_directory/sampleData">Install some sample data</EuiLink> to take a test drive.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea linking to the sample data

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - with green CI. Let me know if you need help getting CI to pass. Dashboard fuctional tests might need to be cleaned up since now both newDashboardLink and createDashboardPromptButton are not visible at the same time.

tested changes
code review

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Jun 12, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Jun 12, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@snide snide merged commit 43639cd into elastic:master Jun 13, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018
Along with @nreese, cleaned up the dashboard listing view to add an empty state.
@nreese
Copy link
Contributor

nreese commented Jul 6, 2018

@snide Is there a reason why this PR was not backported to 6.x? I created #20522 to backport the changes to 6.x

@bhavyarm bhavyarm mentioned this pull request Aug 22, 2018
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants