-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Design] Clean up dashboard listing page #19657
Conversation
@nreese There's a visual hitch where the table loads, then the empty state. Assume this is the way state is being loaded. Not needed now, but it would be nice to do that sort of check before the view is loaded so it removes the "flash". aka...
rather than...
|
@gchaps Yell if you have any better text for that empty screen. Care on that second graph, I'd love for it not to wrap. |
💔 Build Failed |
💔 Build Failed |
jenkins test this |
💔 Build Failed |
@snide Here are some suggestions for the empty state: Create your first dashboard You can combine data views from any Kibana app into one dashboard and see everything in one place. New to Kibana? Install our sample data and test drive the dashboards. Create dashboard For the one-liner (no wrapping) in the graph: Analyze sample flight data for 5 airlines |
💔 Build Failed |
You can combine data views from any Kibana app into one dashboard and see everything in one place. | ||
</p> | ||
<p> | ||
New to Kibana? <EuiLink href="#/home/tutorial_directory/sampleData">Install some sample data</EuiLink> to take a test drive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea linking to the sample data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - with green CI. Let me know if you need help getting CI to pass. Dashboard fuctional tests might need to be cleaned up since now both newDashboardLink
and createDashboardPromptButton
are not visible at the same time.
tested changes
code review
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
jenkins, test this |
💔 Build Failed |
add logic to open dashboard app without top nav
jenkins, test this |
💚 Build Succeeded |
Along with @nreese, cleaned up the dashboard listing view to add an empty state.
Fixes #19652 (comment)