Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to webpack 4 #20105

Closed
wants to merge 18 commits into from
Closed

Upgrade to webpack 4 #20105

wants to merge 18 commits into from

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jun 20, 2018

In order to make working with code splitting and async imports easier in #16253, I've gone ahead and upgraded to webpack 4. This seems to offer a significant advantage in build times (about 20 sec less when starting with no caches) and is working great locally. The primary changes involve the removal of the extract-text-webpack-plugin, and the CommonsChunkPlugin. The functionality of both has been preserved though, switching instead to the mini-css-extract-plugin and using webpack's new built in chunking configuration.

@spalger spalger added review Team:Operations Team label for Operations Team v7.0.0 v6.4.0 labels Jun 20, 2018
@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger
Copy link
Contributor Author

spalger commented Jun 21, 2018

Okay, I might have spoken too soon, I'm seeing very slow rebuild times and OOMs in rebuild... Will take another look tomorrow.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger
Copy link
Contributor Author

spalger commented Jun 23, 2018

Just did a little research, our current module counts by category are:

node_modules: 4143
ui/public: 1016
core_plugins: 806
x-pack: 1519
ui_framework: 147
webpackShims: 10
synthetic: 40
other: 36
total: 7717

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger
Copy link
Contributor Author

spalger commented Jul 3, 2018

We've found a way around needing webpack 4 in #16253, and with the performance issues and the fact that @mistic is also working on improvements to the optimizer that kind of intertwine with this effort... I'm going to close for now.

@spalger spalger closed this Jul 3, 2018
@spalger spalger deleted the upgrade/webpack branch August 18, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team v6.4.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants