-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce EditorConfigProvider to customize vis editor #20519
Changes from all commits
c14cfe8
c8d2e30
a54e820
6b45b70
a3c4c8e
31bd9e3
5b3eeed
84a66eb
a44b1b5
7302f58
f235685
d8137b1
0bef613
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,15 @@ | |
position="'right'" | ||
content="'Interval will be automatically scaled in the event that the provided value creates more buckets than specified by Advanced Setting\'s histogram:maxBars'" | ||
></icon-tip> | ||
|
||
<icon-tip | ||
ng-if="editorConfig.interval.warning" | ||
position="'right'" | ||
content="editorConfig.interval.warning" | ||
type="'alert'" | ||
color="'warning'" | ||
style="float: right" | ||
></icon-tip> | ||
</label> | ||
<input | ||
id="visEditorInterval{{agg.id}}" | ||
|
@@ -14,7 +23,8 @@ | |
type="number" | ||
class="form-control" | ||
name="interval" | ||
min="0" | ||
min="{{editorConfig.interval.base || 0}}" | ||
step="{{editorConfig.interval.base}}" | ||
This comment was marked as resolved.
Sorry, something went wrong. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I have editor hints still on the list, but wanted to pull it into a separate PR. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I actually still added it to this PR. |
||
input-number | ||
> | ||
</div> |
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an explicit test for that