Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Removes alternative docker pull example #20624

Merged
merged 5 commits into from
Jul 11, 2018

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 10, 2018

This PR removes the alternative "docker pull" command so that the instructions are focused on the default path.

cc'ing @jarpy who originally added that information in #14683

Related to elastic/elasticsearch#31934 and elastic/logstash#9831

@elasticmachine
Copy link
Contributor

💔 Build Failed

@tylersmalley
Copy link
Contributor

For some reason, I missing the docker pull section when building docs locally.

screenshot 2018-07-10 11 20 00

@lcawl
Copy link
Contributor Author

lcawl commented Jul 10, 2018

@tylersmalley That is expected on the master branch, due to the following:

ifeval::["{release-state}"!="unreleased"]

@elasticmachine
Copy link
Contributor

💔 Build Failed

@tbragin
Copy link
Contributor

tbragin commented Jul 10, 2018

@lcawl LGTM!

@elasticmachine
Copy link
Contributor

💔 Build Failed

@@ -36,14 +29,17 @@ endif::[]

ifeval::["{release-state}"!="unreleased"]

Docker images can be retrieved with the following commands:
For example, Docker images can be retrieved with the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this become "the Docker image" (singular)?

@lcawl lcawl merged commit 71b1dc6 into elastic:master Jul 11, 2018
@lcawl lcawl deleted the lcawley-docker branch July 11, 2018 16:05
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants