Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable the indexPattern:placeholder setting. Change its value to be an empty string. #20685

Merged
merged 2 commits into from Jul 13, 2018
Merged

Re-enable the indexPattern:placeholder setting. Change its value to be an empty string. #20685

merged 2 commits into from Jul 13, 2018

Conversation

cjcenizal
Copy link
Contributor

Fixes #20611

image

@cjcenizal cjcenizal added bug Fixes for quality problems that affect the customer experience :Management v7.0.0 v6.4.0 labels Jul 11, 2018
@cjcenizal cjcenizal requested review from ruflin and bmcconaghy and removed request for ruflin July 11, 2018 20:21
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ruflin
Copy link
Member

ruflin commented Jul 12, 2018

Code wise LGTM (but not a Kibana expert). Should we really have it empty by default or have it the way it is in the current version with index-name-* somehow in the background as long as the config is not set or empty?

@cjcenizal
Copy link
Contributor Author

@ruflin Thanks for taking a look! When you go to the index pattern creation wizard you'll still see index-name-* in the background of the input. I don't think we need to add similar guidance to the setting itself since someone who comes here to make a change will already be familiar with how index patterns work.

ruflin
ruflin approved these changes Jul 12, 2018
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, makes sense.

bmcconaghy
bmcconaghy approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@cjcenizal cjcenizal merged commit aab75ae into elastic:master Jul 13, 2018
@cjcenizal cjcenizal deleted the bug/re-enable-index-pattern-placeholder branch July 13, 2018 13:39
@cjcenizal cjcenizal mentioned this pull request Jul 13, 2018
Merged
cjcenizal added a commit that referenced this pull request Jul 13, 2018
@cjcenizal
Re-enable the indexPattern:placeholder setting. Change its value to b…
32f0ec7 
…e an empty string. (#20685) (#20768)
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jul 13, 2018
@cjcenizal
Re-enable the indexPattern:placeholder setting. Change its value to b…
f73143c 
…e an empty string. (elastic#20685)
yankouskia pushed a commit to yankouskia/kibana that referenced this pull request Jul 16, 2018
@cjcenizal
Re-enable the indexPattern:placeholder setting. Change its value to b…
7d748b7 
…e an empty string. (elastic#20685)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@bmcconaghy bmcconaghy bmcconaghy approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience v6.4.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cjcenizal @elasticmachine @ruflin @bmcconaghy