TSLint: handle errors in kbn_internal_native_observable types. #20705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
chore
Team:Core
timroes
approved these changes
Jul 12, 2018
💔 Build Failed |
|
aaaand flaky selenium test :/ |
|
retest |
💚 Build Succeeded |
|
6.x/6.4: b77a3a0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out
.d.tsfile can be ignored by TSLint (due to palantir/tslint#3966) socore/lib/kbn_internal_native_observable/index.d.tsmanaged to bypass the checks.Unfortunately if TSLint settings will change the issues in this file won't be detected automatically, unless this file is changed and validated by commit hook. But since this file isn't going to be modified and will be removed relatively soon I just fixed current issues for now (added license header, removed deprecated
declare namespacein favor of singleexportand reordered some class members).How to test: