-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spaces] - Update Roles screen to use public API #21031
[Spaces] - Update Roles screen to use public API #21031
Conversation
💔 Build Failed |
If you edit a role with a "Granted documents query", I'm seeing the toggle default to the wrong state. |
@@ -27,7 +26,7 @@ export class KibanaPrivileges extends Component { | |||
onChange: PropTypes.func.isRequired, | |||
}; | |||
|
|||
idPrefix = () => `${this.props.rbacApplication}_`; | |||
idPrefix = () => `id_`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need the idPrefix? Does it come into play later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may not -- I have another WIP branch that'll butcher a lot of this PR anyway. This is just a stopgap to get the form working again against the new API.
I'm guessing the "Granted documents query" behavior was likely here before this PR, so if you'd like to fix this in another PR, then LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the new Role Management screen to use the public role API introduced as part of #20732.
Additionally, this updates the breadcrumb nav for Spaces and Role management screens to be consistent with the nav introduced in #20739.
There are a couple of visual glitches in this PR which are a result of current defects on master, so they can be safely ignored for the time being.