[ML] Better model memory limit validation #21270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
review
v7.0.0
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui |
peteharverson
approved these changes
Jul 26, 2018
| @@ -1026,6 +1026,12 @@ module.controller('MlNewJob', | |||
| tabs[0].checks.groupIds.message = msg; | |||
| } | |||
|
|
|||
| if (validationResults.contains('model_memory_limit_units_invalid')) { | |||
| tabs[0].checks.modelMemoryLimit.valid = false; | |||
| const msg = `Model memory limit data unit unrecognized. It must be B, KB, MB, GB, TB or PB`; | |||
There was a problem hiding this comment.
Ideally the units in the message should come from the new ALLOWED_DATA_UNITS constant
| @@ -50,6 +50,12 @@ export function populateValidationMessages(validationResults, checks) { | |||
| checks.groupIds.message = msg; | |||
| } | |||
|
|
|||
| if (validationResults.contains('model_memory_limit_units_invalid')) { | |||
| checks.modelMemoryLimit.valid = false; | |||
| const msg = `Model memory limit data unit unrecognized. It must be B, KB, MB, GB, TB or PB`; | |||
There was a problem hiding this comment.
As above, the units referenced in the message should come from ALLOWED_DATA_UNITS .
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jul 27, 2018
This was referenced Jul 27, 2018
jgowdyelastic
added a commit
that referenced
this pull request
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation for the model memory limit value which checks that the unit is an elastic search support unit specified here: https://www.elastic.co/guide/en/elasticsearch/reference/6.x/common-options.html#byte-units
This is run with the normal server side job validation as well as in the job creation pages and in the edit job flyout.
Edit job flyout
Single metric wizard
Multi-metric/Population wizards
Advanced job creation
Job validation modal