Add support for multiple rollup searches. #21755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
jen-huang
reviewed
Aug 7, 2018
| @@ -33,24 +33,23 @@ function getAllFetchParams(searchRequests, Promise) { | |||
| } | |||
|
|
|||
| async function serializeAllFetchParams(fetchParams, searchRequests, serializeFetchParams) { | |||
| const searcRequestsWithFetchParams = []; | |||
There was a problem hiding this comment.
what reviewer let this typo pass?? 😇
|
|
||
| for (let i = 0; i < request.payload.length; i++) { | ||
| const { index, query } = request.payload[i]; | ||
| results.push(await callWithRequest('rollup.search', { |
There was a problem hiding this comment.
using await in a loop blocks the loop iteration until it resolves, right? could we change this a little to use Promise.all instead so that the calls are truly asynchronous?
const results = [];
for (let i = 0; i < request.payload.length; i++) {
const { index, query } = request.payload[i];
results.push(callWithRequest('rollup.search', {
index,
body: query,
}));
}
reply(await Promise.all(results));There was a problem hiding this comment.
So funny, I went on a walk and realized the same thing, and I knew this comment was waiting for me when I came back...
|
@jen-huang Good catch, fixed. |
💔 Build Failed |
jen-huang
pushed a commit
that referenced
this pull request
Aug 10, 2018
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 17, 2018
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 24, 2018
cjcenizal
added a commit
that referenced
this pull request
Sep 4, 2018
jen-huang
pushed a commit
that referenced
this pull request
Sep 7, 2018
cjcenizal
added a commit
that referenced
this pull request
Sep 18, 2018
cjcenizal
added a commit
that referenced
this pull request
Sep 19, 2018
cjcenizal
added a commit
that referenced
this pull request
Sep 28, 2018
cjcenizal
added a commit
that referenced
this pull request
Oct 2, 2018
cjcenizal
added a commit
that referenced
this pull request
Oct 4, 2018
jen-huang
pushed a commit
that referenced
this pull request
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for executing multiple rollup searches in a single request, which enables a dashboard to contain multiple rollup-based visualizations.