Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprectated /shorten API #21861

Merged
merged 4 commits into from Aug 13, 2018

Conversation

Projects
None yet
3 participants
@nreese
Copy link
Contributor

commented Aug 9, 2018

Do not backport

This PR removes the deprecated /shorten API endpoint from master

@nreese

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2018

@epixa Where is the documentation for breaking changes? Or is the tag release_note:breaking enough?

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2018

@nreese

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2018

fail: "apis xpack_main Settings /api/settings with trial license clusters should load multiple clusters"
22:31:06    │ proc  [ftr]            │       
22:31:06    │ proc  [ftr]            │         Error: expected false to sort of equal true
22:31:06    │ proc  [ftr]            │         + expected - actual
22:31:06    │ proc  [ftr]            │       
22:31:06    │ proc  [ftr]            │         -false
22:31:06    │ proc  [ftr]            │         +true
22:31:06    │ proc  [ftr]            │         
22:31:06    │ proc  [ftr]            │         at Assertion.assert (node_modules/expect.js/index.js:96:13)
22:31:06    │ proc  [ftr]            │         at Assertion.eql (node_modules/expect.js/index.js:230:10)
22:31:06    │ proc  [ftr]            │         at Context.it (test/api_integration/apis/xpack_main/settings/settings.js:37:59)
22:31:06    │ proc  [ftr]            │         at <anonymous>

jenkins, test this

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 10, 2018

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 10, 2018

@nreese nreese referenced this pull request Aug 10, 2018

Merged

Upgrade to EUI 3.4.0 #21870

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 10, 2018

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 10, 2018

@nreese nreese requested a review from chrisdavies Aug 10, 2018

@chrisdavies
Copy link
Contributor

left a comment

LGTM. Just code review.

@nreese nreese merged commit a0dd3e6 into elastic:master Aug 13, 2018

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 21, 2018

remove deprectated /shorten API (elastic#21861)
* remove deprectated /shorten API

* breaking change log

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 23, 2018

remove deprectated /shorten API (elastic#21861)
* remove deprectated /shorten API

* breaking change log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.