Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprectated /shorten API #21861

Merged
merged 4 commits into from Aug 13, 2018
Merged

remove deprectated /shorten API #21861

merged 4 commits into from Aug 13, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 9, 2018

Do not backport

This PR removes the deprecated /shorten API endpoint from master

@nreese
Copy link
Contributor Author

nreese commented Aug 9, 2018

@epixa Where is the documentation for breaking changes? Or is the tag release_note:breaking enough?

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor Author

nreese commented Aug 9, 2018

fail: "apis xpack_main Settings /api/settings with trial license clusters should load multiple clusters"
22:31:06    │ proc  [ftr]            │       
22:31:06    │ proc  [ftr]            │         Error: expected false to sort of equal true
22:31:06    │ proc  [ftr]            │         + expected - actual
22:31:06    │ proc  [ftr]            │       
22:31:06    │ proc  [ftr]            │         -false
22:31:06    │ proc  [ftr]            │         +true
22:31:06    │ proc  [ftr]            │         
22:31:06    │ proc  [ftr]            │         at Assertion.assert (node_modules/expect.js/index.js:96:13)
22:31:06    │ proc  [ftr]            │         at Assertion.eql (node_modules/expect.js/index.js:230:10)
22:31:06    │ proc  [ftr]            │         at Context.it (test/api_integration/apis/xpack_main/settings/settings.js:37:59)
22:31:06    │ proc  [ftr]            │         at <anonymous>

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese nreese mentioned this pull request Aug 10, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@chrisdavies chrisdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just code review.

@nreese nreese merged commit a0dd3e6 into elastic:master Aug 13, 2018
cjcenizal pushed a commit to cjcenizal/kibana that referenced this pull request Aug 21, 2018
* remove deprectated /shorten API

* breaking change log
cjcenizal pushed a commit to cjcenizal/kibana that referenced this pull request Aug 23, 2018
* remove deprectated /shorten API

* breaking change log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants