Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate base path APIs and UiSettings client to new platform #22694

Merged
merged 26 commits into from
Sep 8, 2018
Merged

Migrate base path APIs and UiSettings client to new platform #22694

merged 26 commits into from
Sep 8, 2018

Commits on Sep 4, 2018

  1. create basePath service for new platform

    @spalger
    spalger authored and spalger committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    d02cd0e View commit details
    Browse the repository at this point in the history

  2. migrate ui settings to new platform

    @spalger
    spalger authored and spalger committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    68f7f01 View commit details
    Browse the repository at this point in the history

  3. [ui/core/uiSetttings] actually await expect(promise) calls

    @spalger
    spalger committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    743b553 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2018

  1. Merge branch 'master' of github.com:elastic/kibana into HEAD

    spalger committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    9618563 View commit details
    Browse the repository at this point in the history

  2. [ui/core/uiSettings] add tests for uiSettingsService

    spalger committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    df345e1 View commit details
    Browse the repository at this point in the history

  3. test out mock class helper

    spalger committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    05d9b8e View commit details
    Browse the repository at this point in the history

  4. fix reference to uiSettings.subscribe()

    spalger committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    b772a7d View commit details
    Browse the repository at this point in the history

  5. [ui/chrome/test] derive basePath from internals like legacy implement… 

    …ation did
    spalger committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    4691b7b View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2018

  1. Merge branch 'master' of github.com:elastic/kibana into migrate-new-p… 

    …latform/ui-settings-client
    spalger committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    dc9f43b View commit details
    Browse the repository at this point in the history

  2. [core/public/uiSettingsClient/types] include all properties, even uns… 

    …ed ones
    spalger committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    dc5ddc7 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2018

  1. fix typos

    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    02f0cc9 View commit details
    Browse the repository at this point in the history

  2. limit exported types to those in use

    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    63bcb4d View commit details
    Browse the repository at this point in the history

  3. remove unnecessary copy of modify_url util in ui/public

    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    f5e6643 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary types from JSDoc

    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    1bcd411 View commit details
    Browse the repository at this point in the history

  5. use Number constructor rather than parseInt

    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    60d8924 View commit details
    Browse the repository at this point in the history

  6. [core/public/legacyService] test that uiSettings is initialized

    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    cf2e10f View commit details
    Browse the repository at this point in the history

  7. [core/public/uiSettingsClient] use readonly when possible

    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    a7db8fd View commit details
    Browse the repository at this point in the history

  8. [core/public/uiSettingsClient] use imported type since available

    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    ea4cf06 View commit details
    Browse the repository at this point in the history

  9. [core/public/uiSettingsClient] remove unnecessary Boolean cast

    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    ddbd2b8 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' of github.com:elastic/kibana into migrate-new-p… 

    …latform/ui-settings-client
    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    8dec538 View commit details
    Browse the repository at this point in the history

  11. [core/public/basePath/removeBasePath] handle a couple edge-cases better

    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    d2f5816 View commit details
    Browse the repository at this point in the history

  12. fix modifyUrl import

    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    aa60f3e View commit details
    Browse the repository at this point in the history

  13. fix another modifyUrl import (this time run eslint to verify :P)

    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    aac0a7c View commit details
    Browse the repository at this point in the history

  14. Merge branch 'master' of github.com:elastic/kibana into migrate-new-p… 

    …latform/ui-settings-client
    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    19eb622 View commit details
    Browse the repository at this point in the history

  15. [jest] update snapshots

    @spalger
    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    b1a6ddf View commit details
    Browse the repository at this point in the history

  16. import directly from core when necessary to avoid infecting jest with… 

    … angular
    spalger committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    596ca89 View commit details
    Browse the repository at this point in the history