remove useUTC deprecation, set default timezone to local #22696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
release_note:breaking
Team:Core
jbudz
force-pushed
the
server-tz-local
branch
from
cf49c11
to
d5035d0
Compare
jbudz
commented
Sep 4, 2018
src/server/config/schema.js
Outdated
| @@ -186,7 +186,7 @@ export default () => Joi.object({ | |||
| then: Joi.default(!process.stdout.isTTY), | |||
| otherwise: Joi.default(true) | |||
| }), | |||
| timezone: Joi.string().allow(false).default('UTC') | |||
| timezone: Joi.string().allow(false).default(false) | |||
There was a problem hiding this comment.
by false this means don't set it, which uses moments default (local timezone). i was hesitant to add a non-standard string to the list.
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
|
Pinging @elastic/kibana-operations |
💔 Build Failed |
💚 Build Succeeded |
jbudz
added
the
non-issue
This was referenced Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #21561, 8.0 only.
Removes our deprecation notice and sets the default timezone to the host machines timezone.
Closes #12175