[ML] Deprecates the use of jQuery for rendering Anomaly Explorer Swimlanes #23000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
v7.0.0
:ml
refactoring
Feature:ml-results
|
Pinging @elastic/ml-ui |
💔 Build Failed |
|
retest |
| $('.sl-cell-inner,.sl-cell-inner-dragselect', '.ml-explorer-swimlane').addClass('sl-cell-inner-masked'); | ||
| $('.sl-cell-inner.sl-cell-inner-selected,.sl-cell-inner-dragselect.sl-cell-inner-selected', | ||
| '.ml-explorer-swimlane').removeClass('sl-cell-inner-selected'); | ||
| // This select both overall and viewby swimlane |
There was a problem hiding this comment.
nit - should be This selects ...
| $('.sl-cell-inner-dragselect.sl-cell-inner-selected', '.ml-explorer-swimlane').removeClass('sl-cell-inner-selected'); | ||
| $('.ds-selected', '.ml-explorer-swimlane').removeClass('ds-selected'); | ||
|
|
||
| // This select both overall and viewby swimlane |
There was a problem hiding this comment.
nit - should be selects
| return (e) => { | ||
| cellMouseover(e, safeLaneTxt, bucketScore, i, time); | ||
| }; | ||
| const safeLaneTxt = lane.replace(/(['\\])/g, '\\$1'); |
There was a problem hiding this comment.
Have you tested this with any datasets which contain partitioning field names and values with 'special' characters in, such as quotes, spaces, backslashes. Just worth double checking that all the functionality works as expected.
💚 Build Succeeded |
peteharverson
approved these changes
Sep 14, 2018
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Sep 14, 2018
…lanes (elastic#23000) - This refactor gets rid of jQuery as a requirement for the Anomaly Explorer Swimlanes. All the DOM manipulation previously done by jQuery is now done by d3. - The primary aim here is to replace jQuery with d3. To avoid refactoring regressions, this PR sticks as much as possible to the original structure. Overall, this could be done in a more "d3"-way, but it's a good start. - The resulting DOM is a bit different: The structure is exactly the same, just how we use certain data-attributes changed. - Instead of using jQuery's data-feature for storing click event data, that data is now directly stored on DOM nodes. Again, this could be done in a more "d3"-way but would require quite some further refactoring.
walterra
added a commit
that referenced
this pull request
Sep 17, 2018
…lanes (#23000) (#23193) - This refactor gets rid of jQuery as a requirement for the Anomaly Explorer Swimlanes. All the DOM manipulation previously done by jQuery is now done by d3. - The primary aim here is to replace jQuery with d3. To avoid refactoring regressions, this PR sticks as much as possible to the original structure. Overall, this could be done in a more "d3"-way, but it's a good start. - The resulting DOM is a bit different: The structure is exactly the same, just how we use certain data-attributes changed. - Instead of using jQuery's data-feature for storing click event data, that data is now directly stored on DOM nodes. Again, this could be done in a more "d3"-way but would require quite some further refactoring.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor gets rid of jQuery as a requirement for the Anomaly Explorer Swimlanes. All the DOM manipulation previously done by jQuery is now done by d3.
Notes:
Possible Todos for a follow-up:
clearSelection()orselectCell()shouldn't really manipulate the DOM. They should just manipulate state and trigger a re-render. The rendering function then should take care of considering that state change and render accordingly.Part of #22642.