Remove notes about babel deoptimizing #23757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2018 07:31
💚 Build Succeeded |
rashidkpc
added
the
Team:Presentation
|
This isn't relevant anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the babel notices we were seeing when starting Kibana. We shouldn't need to babel of our plugin since they're already babeled in the build step.
You'll notice that I could've just put a single ignore for
"canvas_plugin/**/*.js"I didn't, mostly because we'll need to remove the
functions/serverline when we merge #23290Testing
--no-base-path[BABEL] Note: The code generator has deoptimised the styling of "/Users/rashidkpc/Projects/kibana/x-pack/plugins/canvas/canvas_plugin/...--no-base-path