Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] correcting position of jobs list components props #24198

Merged
merged 1 commit into from
Oct 18, 2018
Merged

[ML] correcting position of jobs list components props #24198

merged 1 commit into from
Oct 18, 2018

Conversation

jgowdyelastic
Copy link
Member

Recent manual backport #24138 missed only added one allJobIds props and in the wrong location.
This corrects that mistake.

@jgowdyelastic jgowdyelastic self-assigned this Oct 18, 2018
@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml v6.5.0 labels Oct 18, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

peteharverson
peteharverson approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌 ⚡️

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

retest

@jgowdyelastic jgowdyelastic force-pushed the correcting-position-of-jobs-list-component-props branch from 5e431db to 538d60f Compare October 18, 2018 12:25
@elasticmachine
Copy link
Contributor

💔 Build Failed

@alvarezmelissa87
Copy link
Contributor

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit 691f6c4 into elastic:6.x Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
:ml non-issue Indicates to automation that a pull request should not appear in the release notes review v6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jgowdyelastic @elasticmachine @alvarezmelissa87 @peteharverson