Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Add tests for the log entries and summary api #24354

Merged
merged 4 commits into from
Oct 24, 2018

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented Oct 22, 2018

Summary

This adds api tests for the following fields of the InfraOps GraphQL api:

  • source.logEntriesAround
  • source.logEntriesBetween
  • source.logSummaryBetween

Checklist

For maintainers

@weltenwort weltenwort added WIP Work in progress v7.0.0 v6.5.0 Feature:Metrics UI Metrics UI feature loe:small Small Level of Effort labels Oct 22, 2018
@weltenwort weltenwort self-assigned this Oct 22, 2018
@weltenwort weltenwort added this to In progress in Infra UI via automation Oct 22, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@weltenwort weltenwort changed the title Infra UI] Add tests for the log entries and summary api (2nd attempt) [Infra UI] Add tests for the log entries and summary api Oct 23, 2018
@weltenwort weltenwort requested a review from skh October 23, 2018 21:19
Copy link
Contributor

@skh skh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@weltenwort weltenwort removed the WIP Work in progress label Oct 24, 2018
@weltenwort weltenwort merged commit c4e7b2f into elastic:master Oct 24, 2018
Infra UI automation moved this from In progress to Done Oct 24, 2018
weltenwort added a commit to weltenwort/kibana that referenced this pull request Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature loe:small Small Level of Effort v6.5.0 v7.0.0
Projects
No open projects
Infra UI
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants