-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra UI] Add tests for the log entries and summary api #24354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
WIP
Work in progress
v7.0.0
v6.5.0
Feature:Metrics UI
Metrics UI feature
loe:small
Small Level of Effort
labels
Oct 22, 2018
💔 Build Failed |
8 tasks
weltenwort
force-pushed
the
infra-ui-test-api-logs
branch
from
October 23, 2018 15:17
78e16a8
to
156d666
Compare
💚 Build Succeeded |
💚 Build Succeeded |
weltenwort
changed the title
Infra UI] Add tests for the log entries and summary api (2nd attempt)
[Infra UI] Add tests for the log entries and summary api
Oct 23, 2018
skh
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Oct 24, 2018
weltenwort
added a commit
that referenced
this pull request
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds api tests for the following fields of the InfraOps GraphQL api:
source.logEntriesAround
source.logEntriesBetween
source.logSummaryBetween
Checklist
This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately