Remove red color from the kbn-pm logs #24362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
review
Team:Operations
💚 Build Succeeded |
|
Mind just removing red? We don't have to replace with anything. |
mistic
changed the title
|
@tylersmalley yeah I agree! Just removed the red color without any replace 😃 |
💚 Build Succeeded |
|
@mistic I don't think you pushed that change. |
|
Thanks @tylersmalley I just updated it right now. I just had forgotten to update the kbn-pm dist file. What an 🦅 eye you have 😄 |
tylersmalley
approved these changes
Oct 23, 2018
💚 Build Succeeded |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Oct 23, 2018
* feat(NA): remove red color from the kbn-pm logs. * refact(NA): removed gray color from the generateColors function. * chore(NA): update missing km pm dist file.
mistic
added a commit
that referenced
this pull request
Oct 23, 2018
|
6.x: 3d1e00a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR that just replaces the red color by the gray one into the logs from kbn-pm. As the
kbn bootstrapwill run into our CI we don't want to have red output logs other than errors there.