Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] fixes #24563 by de-duping the column field id 'sample' #24690

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import React from 'react';
import styled from 'styled-components';
import { Transaction } from '../../../../typings/Transaction';
import { ITransactionGroup } from '../../../../typings/TransactionGroup';
import { fontSizes, truncate } from '../../../style/variables';
// @ts-ignore
Expand All @@ -30,23 +29,22 @@ interface Props {

const traceListColumns: ITableColumn[] = [
{
field: 'sample',
field: 'name',
jasonrhodes marked this conversation as resolved.
Show resolved Hide resolved
name: 'Name',
width: '40%',
sortable: true,
render: (transaction: Transaction) => (
<TooltipOverlay content={transaction.transaction.name}>
<StyledTransactionLink transaction={transaction}>
{transaction.transaction.name}
render: (name, group: ITransactionGroup) => (
<TooltipOverlay content={name}>
<StyledTransactionLink transaction={group.sample}>
{name}
</StyledTransactionLink>
</TooltipOverlay>
)
},
{
field: 'sample',
field: 'sample.context.service.name',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woop, didn't know EUI supported this!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha yep, EUI doesn't care, it just hands back that field string to you.

name: 'Originating service',
sortable: true,
render: (transaction: Transaction) => transaction.context.service.name
sortable: true
},
{
field: 'averageResponseTime',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export interface ITableColumn {
align?: string;
width?: string;
sortable?: boolean;
render: (value: any, item?: any) => any;
render?: (value: any, item?: any) => any;
}

export interface IManagedTableProps {
Expand Down