Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple query #24745

Merged
merged 7 commits into from
Oct 30, 2018
Merged

Simple query #24745

merged 7 commits into from
Oct 30, 2018

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Oct 29, 2018

we just wanted to create a simple example to show the interaction between container and pages folder.
And also to create a small query with grapql like that:

  source(id: "default") {
    whoIsThis{
      appName
    }
  }
}

@XavierM XavierM added review loe:small Small Level of Effort Team:SIEM labels Oct 29, 2018
@XavierM XavierM self-assigned this Oct 29, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@XavierM
Copy link
Contributor Author

XavierM commented Oct 29, 2018

I need to add Test but we can still see how it works for now

@elasticmachine
Copy link
Contributor

💔 Build Failed

@FrankHassanabad
Copy link
Contributor

Build failure is case sensitivity issues:

10:28:53 
10:28:53 plugins/secops/public/containers/who_am_i/index.tsx:11:29 - error TS2307: Cannot find module './who_am_I.gql_query'.
10:28:53 
10:28:53 11 import { whoAmIQuery } from './who_am_I.gql_query';
10:28:53                                ~~~~~~~~~~~~~~~~~~~~~~
10:28:53 
10:28:53

@FrankHassanabad
Copy link
Contributor

Pre-approved this as long as builds work and are green I am fine with this being merged.

FrankHassanabad
FrankHassanabad approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as builds and conflicts are resolved this looks good. If Unit tests are added, I will re-review those with this again.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

andrew-goldstein
andrew-goldstein approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@XavierM XavierM merged commit 2055eab into elastic:feature-secops Oct 30, 2018
andrew-goldstein pushed a commit that referenced this pull request Dec 4, 2018
@XavierM @andrew-goldstein
Simple query (#24745)
a69f4d4 
* Translations for Region Map (#23875)

add translations for region_map plugin

* Translations for Table Vis plugin (#23679)

add translations for table vis plugin

* add a simple example/flow to see what need to be done to query with graphql

* work review

* simple test for source schema

* fix some reviewing and add resolver test code for source

* review by Andrew G
@XavierM XavierM deleted the simple-query branch March 20, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees

@XavierM XavierM

Labels
loe:small Small Level of Effort review Team:SIEM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@XavierM @elasticmachine @FrankHassanabad @andrew-goldstein @pavel06081991