Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.4] Reporting Cookies #24752 #24794

Merged
merged 4 commits into from Oct 30, 2018
Merged

[6.4] Reporting Cookies #24752 #24794

merged 4 commits into from Oct 30, 2018

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Oct 29, 2018

Backporting #24752 to 6.4

@kobelb kobelb changed the title [6.4] Backport #24752 [6.4] Backport Reporting Cookies #24752 Oct 29, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@kobelb kobelb changed the title [6.4] Backport Reporting Cookies #24752 [6.4] Reporting Cookies #24752 Oct 29, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

stacey-gammon
stacey-gammon approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, testing with ssl and a base path, with vega, a markdown and a map. Map sometimes failed to show data but that is an existing issue.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Contributor

probably flaky :
UI Functional Tests.test/functional/apps/dashboard/_dashboard_listing·js.dashboard app using legacy data dashboard listing page search by title stays on listing page if title matches two dashboards

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kobelb kobelb merged commit 968768f into elastic:6.4 Oct 30, 2018
@kobelb kobelb deleted the backport/6.4-24752 branch October 30, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacey-gammon stacey-gammon stacey-gammon approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kobelb @elasticmachine @stacey-gammon @chrisdavies