Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add png output to reports 65 (#24759) #25018

Merged
merged 2 commits into from Nov 2, 2018

Conversation

stacey-gammon
Copy link
Contributor

  • Changes for new PNG image output for reports

Change PNG button name from Download to Generate

Changes for new PNG image output for reports

Change PNG button name from Download to Generate

Remove compatabilityShim from PNG and move to PDF folders

Changed API parameters to contain only required parameters

Added test cases for PNG reporting and added title back into the PNG API call

Merge of security changes for PNG reporting

Fixed issues with test cases for both PDF and PNG

Updated test snapshots for PNG and PDF test changes

  • Adding new security changes made for PDF into new PNG code

  • Removed commented out lines that were not needed

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

* Changes for new PNG image output for reports

Change PNG button name from Download to Generate

Changes for new PNG image output for reports

Change PNG button name from Download to Generate

Remove compatabilityShim from PNG and move to PDF folders

Changed API parameters to contain only required parameters

Added test cases for PNG reporting and added title back into the PNG API call

Merge of security changes for PNG reporting

Fixed issues with test cases for both PDF and PNG

Updated test snapshots for PNG and PDF test changes

* Adding new security changes made for PDF into new PNG code

* Removed commented out lines that were not needed
@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon stacey-gammon changed the title Add png output to reports 65 (#24759) [6.x] Add png output to reports 65 (#24759) Nov 2, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stacey-gammon stacey-gammon merged commit cae5a0d into elastic:6.x Nov 2, 2018
@tsullivan tsullivan mentioned this pull request Jan 24, 2019
@stacey-gammon stacey-gammon deleted the 6.x/export_to_png branch February 12, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants