Fix: Run with reporting disabled #25829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w33ble
added
review
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
💚 Build Succeeded |
|
rashidkpc
approved these changes
Nov 19, 2018
|
Why is the error message calling out Chromium instead of the enabled/disabled setting? Just might be confusing since chromium is the default now, so they shouldn't actually have to add that, just make sure it's not set to phantom, and make sure it's not disabled. |
|
@stacey-gammon yeah, I was thinking about that too. Planning to make a follow-on PR that shows a different message when Reporting is just disabled. Opened #26357 to track it. |
clintandrewhall
approved these changes
Nov 28, 2018
|
@clintandrewhall I really should proof-read what I write I guess, heh. Thanks for the review. |
w33ble
force-pushed
the
fix/run-with-reporting-disabled
branch
from
0a1196f
to
50cff8d
Compare
the code was duplicated from canvas, so it's equally as broken, this duplicates the fix
|
Quick refactor and addition after testing on master. It was broken there too, in a different way, thanks to code duplication (as mentioned in #26375). Was seeing this error: |
💚 Build Succeeded |
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Nov 28, 2018
* fix: relative link instead of static * fix: handle missing reporting config value * chore: refactor reportingBrowserType check * fix: core interpreter reportingBrowserType the code was duplicated from canvas, so it's equally as broken, this duplicates the fix
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Nov 28, 2018
* fix: relative link instead of static * fix: handle missing reporting config value * chore: refactor reportingBrowserType check * fix: core interpreter reportingBrowserType the code was duplicated from canvas, so it's equally as broken, this duplicates the fix
w33ble
added a commit
that referenced
this pull request
Nov 29, 2018
* fix: relative link instead of static * fix: handle missing reporting config value * chore: refactor reportingBrowserType check * fix: core interpreter reportingBrowserType the code was duplicated from canvas, so it's equally as broken, this duplicates the fix
w33ble
added a commit
that referenced
this pull request
Nov 29, 2018
* fix: relative link instead of static * fix: handle missing reporting config value * chore: refactor reportingBrowserType check * fix: core interpreter reportingBrowserType the code was duplicated from canvas, so it's equally as broken, this duplicates the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25728
Fixes reporting import and config checking.
pluginsaliasconfig.getso it doesn't throw when reporting is disabledTo test, simply set
xpack.reporting.enabled: falsein your kibana.yml. Previously, it would fail to build, and crash the server even if it would.