Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add en for numeral locale setting #25948

Merged
merged 1 commit into from Nov 22, 2018
Merged

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Nov 20, 2018

Summary

Fixes #22991, fixes #25793, Add en as a valid locale to the settings.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@timroes timroes added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure kbn-management labels Nov 20, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested on chrome/osx

@timroes timroes merged commit bcb5ee0 into elastic:master Nov 22, 2018
@timroes timroes deleted the en-numeral-locale branch November 22, 2018 09:12
timroes added a commit to timroes/kibana that referenced this pull request Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0 v7.0.0
Projects
None yet
3 participants