Bug fix - Graph UI settings not displayed, reverting to master's settings.html #26008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tings.html The 6.x and 6.5 branches had broken settings.html (would not show 'advanced settings' or 'drill down' tabs). To fix I have made a straight copy-paste of master’s settings.html which has diverged from the 6.x branches for reasons unknown to me. Master and 6.x should have no functional difference and this change works as I would expect but by copy/pasting like this I am obliterating any previous work here on the 6.5/6.x branch which may relate to styling etc.
markharwood
added
bug
|
Pinging @elastic/kibana-app |
💔 Build Failed |
|
Jenkins, test this |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as PR #25927
The 6.x and 6.5 branches had broken settings.html (would not show 'advanced settings' or 'drill down' tabs).
To fix I have made a straight copy-paste of master’s settings.html which has diverged from the 6.x branches for reasons unknown to me.
Master and 6.x should have no functional difference and this change works as I would expect but by copy/pasting like this I am obliterating any previous work here on the 6.5/6.x branch which may relate to styling etc.