-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[discover] implement k7Breadcrumbs #26587
[discover] implement k7Breadcrumbs #26587
Conversation
Pinging @elastic/kibana-app |
@cchaos re 1, I'm not sure. I tried putting the id, or the index, in the breadcrumb, but they both just got tucked into ellipses and then I kind of figured that "Context" kind of described this page better than "Surrounding ...". re 2, yeah, it probably should. |
|
Maybe the breadcrumbs should be:
for context, and
for single doc viewer, and get rid of that extra title and "Surrounding Documents..." and the tabs. But then do we think it's important to show the index pattern name somewhere? |
I think the index pattern is more important than the type ( Avoiding truncation of the last breadcrumb based on available space would ease my worries, so let's go for that! |
💔 Build Failed |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that makes sense to me!
Fixes #25894
Summary
This PR updates the discover routes to provide k7Breadcrumbs used by the new header navigation. See #25884 for general information about the integration with the router and #25689 for the breadcrumb taxonomy
Checklist