Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[graph] implement k7Breadcrumbs #26591

Merged
merged 4 commits into from
Dec 4, 2018
Merged

[graph] implement k7Breadcrumbs #26591

merged 4 commits into from
Dec 4, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Dec 3, 2018 •
edited
Loading

Fixes #25901

Summary

This PR updates the graph route to provide k7Breadcrumbs used by the new header navigation. See #25884 for general information about the integration with the router and #25689 for the breadcrumb taxonomy

2018-12-03 15 36 49

Checklist

@spalger spalger added review v7.0.0 Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 3, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@spalger spalger requested a review from cchaos December 3, 2018 23:40
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cchaos
Copy link
Contributor

cchaos commented Dec 4, 2018

Can you put the name of the workspace up in the breadcrumbs, and have the "Graph" breadcrumb trigger the "New" action?

@spalger
Copy link
Contributor Author

spalger commented Dec 4, 2018 •
edited
Loading

You got it, not sure why I was so lazy with this one 😄

@cchaos
Copy link
Contributor

cchaos commented Dec 4, 2018

Will you also be removing the name of the workspace from the kuiNav area?

@spalger
Copy link
Contributor Author

spalger commented Dec 4, 2018

Alright, hid the title in when the k7design is active

cchaos
cchaos approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit 757f836 into elastic:master Dec 4, 2018
@spalger spalger deleted the implement/k7-breadcrumbs/graph branch December 4, 2018 20:10
@Nox911
Copy link
Contributor

Nox911 commented Jan 21, 2019

@spalger is this PR supposed to be backported to 6.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
Feature:Graph Graph application feature review Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spalger @elasticmachine @cchaos @Nox911