[I18n] Fix pseudo-localization of i18n directive placeholders #26948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeanidShutau
added
bug
|
Pinging @elastic/kibana-platform |
💚 Build Succeeded |
pavel06081991
approved these changes
Dec 11, 2018
Bamieh
requested changes
Dec 13, 2018
|
@LeanidShutau Looks good, placeholders are only words? no |
💔 Build Failed |
💔 Build Failed |
…ders-pseudo-localization
💚 Build Succeeded |
LeanidShutau
added a commit
to LeanidShutau/kibana
that referenced
this pull request
Dec 14, 2018
…c#26948) * [I18n] Fix pseudo-localization of i18n directive placeholders * Add a unit test * Add more tests
LeanidShutau
added a commit
that referenced
this pull request
Dec 17, 2018
#27192) * [I18n] Fix pseudo-localization of i18n directive placeholders * Add a unit test * Add more tests
|
6.x/6.6: 85780a2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
In #26274 we have added
@I18N@placeholders for html values ini18n-valuesattribute. Pseudo-localization localizes these placeholders, so they cannot be replaced by their original values after pseudo-localization. It breaks messages withhtml_values whenen-xalocale is used.Fix
Update pseudo-localization RegExp to ignore
@I18N@valueName@I18N@sub-strings.How to test
Enable pseudo-locale (
yarn start --i18n.locale en-xaor seti18n.locale: "ex-xa"inkibana.yml).Open Timelion -> Help:
@I18N@placeholders in the text and no rendered html code;