Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Fix: Support columns with dots (#26659) #26993

Merged
merged 1 commit into from Dec 11, 2018
Merged

[6.x] Fix: Support columns with dots (#26659) #26993

merged 1 commit into from Dec 11, 2018

Conversation

w33ble
Copy link
Contributor

@w33ble w33ble commented Dec 11, 2018

Backports the following commits to 6.x:

@w33ble
Fix: Support columns with dots (elastic#26659)
a3a339d 
Closes elastic#26405

Upgrades tinymath so that columns with dots now work correctly.

---

To test, follow the details in elastic#26405.

1. Get some data that has fields with dots in them. Beats data would work, or you can create a test index with just 2 documents as follows: 

```
POST test/test
{
  "string":"abc",
  "with.dot":"abc"
}
POST test/test
{
  "string":"abcd",
  "with.dot":"abcd"
}
```

2. Create a pie chart, splitting labels on one of the available fields.

Previously, given the POST info above, only `string` would work correctly. Now both (and both of their `.keyword` variants) work correctly.

![dec-04-2018 13-35-47](https://user-images.githubusercontent.com/404731/49473970-b2cf7a00-f7d0-11e8-995b-e1a5e2a2acba.gif)
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@w33ble w33ble merged commit ebdba85 into elastic:6.x Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@w33ble @elasticmachine