New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding new specs for security endpoints without _xpack prefix #27057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcconaghy
added
v7.0.0
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v6.7.0
labels
Dec 12, 2018
💚 Build Succeeded |
kobelb
reviewed
Dec 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some overrides for the xpack.security.* endpoints, should we be duplicating those for these new endpoints?
Yes we should, thanks for catching @kobelb . Pushed those. |
kobelb
approved these changes
Dec 17, 2018
💔 Build Failed |
💔 Build Failed |
kobelb
reviewed
Dec 17, 2018
x-pack/plugins/console_extensions/spec/generated/security.delete_privileges.json
Show resolved
Hide resolved
retest |
💚 Build Succeeded |
bmcconaghy
added a commit
to bmcconaghy/kibana
that referenced
this pull request
Dec 18, 2018
…c#27057) * adding new specs for security endpoints without _xpack prefix * adding overrides * fixing issues with autocomplete and missing docs
bmcconaghy
added a commit
that referenced
this pull request
Dec 18, 2018
#27391) * adding new specs for security endpoints without _xpack prefix * adding overrides * fixing issues with autocomplete and missing docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v6.6.0
v7.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated new specs for the API changes to remove _xpack prefix from security APIs.