[ML] Ensure loading indicator is present on initial jobs load #27151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
requested review from
walterra,
peteharverson and
jgowdyelastic
alvarezmelissa87
added
review
enhancement
|
Pinging @elastic/ml-ui |
|
I noticed that the Does it feel okay to do that refactor in this PR or do it separately? |
💔 Build Failed |
|
retest |
💔 Build Failed |
|
@alvarezmelissa87 i'm fine with that refactor happening in this PR. it won't be big. |
x-pack/plugins/ml/public/jobs/jobs_list/components/jobs_list_view/jobs_list_view.js
Show resolved
Hide resolved
|
@alvarezmelissa87 refactoring |
|
This has been updated with the |
💔 Build Failed |
alvarezmelissa87
force-pushed
the
ml-job-list-loading-indicator
branch
from
37a7f1a
to
9fb809b
Compare
💚 Build Succeeded |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Dec 14, 2018
…c#27151) * Show table loading on initial jobs load * Use async/await and try/catch to catch job load failure
alvarezmelissa87
added a commit
that referenced
this pull request
Dec 14, 2018
#27231) * Show table loading on initial jobs load * Use async/await and try/catch to catch job load failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #26418
loadingtoJobsListViewstate with initialnullvalue.loadingset tonull, it is set totruewhen loading job list - this ensures loading indicator is shown on first page load only.JobsListUI(containing the job list table) receivesloadingas prop.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately