[skip ci] prototype for saved objects relationships #27155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
WIP
|
Pinging @elastic/kibana-platform |
mikecote
commented
Dec 13, 2018
| return this.hydrateIndexPattern(); | ||
| }).then(() => { | ||
| injectReferences.call(this, resp.references); |
There was a problem hiding this comment.
This can probably be moved after parseSearchSource and implemented in a way that doesn't touch this.
mikecote
commented
Dec 13, 2018
| panel.type = reference.type; | ||
| delete panel.panelReference; | ||
| }); | ||
| this.panelsJSON = JSON.stringify(panels); |
There was a problem hiding this comment.
Probably have a way that doesn't modify this and works with arguments instead.
mikecote
force-pushed
the
saved-objects-relationships-prototype
branch
from
ce1afed
to
11f7e20
Compare
mikecote
force-pushed
the
saved-objects-relationships-prototype
branch
from
11f7e20
to
b0b9333
Compare
|
Closing this in favour of the implementation PR (#28199) that is based from this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not merge
I wrote up a basic prototype of how we can save references into each saved objects and put them back into the object after reading.
This prototype is functional for dashboards, visualizations (from index pattern) and saved searches. What's left is visualizations from a saved search and test timelion / graph for index patterns.
See #27210.