Adds custom font size to list of sizes options #27785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqliu1
added
review
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
💔 Build Failed |
|
CI failure seems pretty unrelated... was this created from the latest master? Maybe a rebase will cure it? I was having problems last week that seems to have been resolved. |
💚 Build Succeeded |
|
Sweet, flakey tests! |
ryankeairns
approved these changes
Dec 26, 2018
w33ble
reviewed
Dec 26, 2018
| @@ -64,6 +64,11 @@ export const TextStylePicker = ({ | |||
| ['underline']: Boolean(underline), | |||
| }; | |||
|
|
|||
| if (!isNaN(size) && fontSizes.indexOf(Number(size)) === -1) { | |||
There was a problem hiding this comment.
Is the isNaN check required here? Invalid values come in as NaNpx (another bug honestly), and then the dropdown still just shows 0. This isn't really a problem (it's edge case and is caused by another problem) and I'm not sure what else it would show, but thought I'd ask.
There was a problem hiding this comment.
Opened an issue for the NaN thing I mentioned: #27788
w33ble
approved these changes
Dec 26, 2018
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Dec 26, 2018
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Dec 26, 2018
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Dec 26, 2018
cqliu1
added a commit
that referenced
this pull request
Dec 26, 2018
cqliu1
added a commit
that referenced
this pull request
Dec 26, 2018
cqliu1
added a commit
that referenced
this pull request
Dec 26, 2018
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24936.
If you set the font size to a value not in our built in list of sizes, the value would display as
0in the sidebar. This adds a check to add a value to the array of font sizes if the value doesn't already exist.