[GIS] Updates mapping to reflect that in ES #28038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
|
@elastic/kibana-gis someone mind sighing off on this change? |
nreese
reviewed
Jan 4, 2019
x-pack/plugins/gis/mappings.json
Outdated
| @@ -12,7 +12,7 @@ | |||
| }, | |||
| "bounds": { | |||
| "type": "geo_shape", | |||
| "tree": "quadtree" | |||
| "strategy": "recursive" | |||
There was a problem hiding this comment.
You can remove strategy as well. In 6.6, geo_shape type was update to be implemented with BKD tree and all of these configuration are no longer needed. https://www.elastic.co/guide/en/elasticsearch/reference/6.x/geo-shape.html#geoshape-indexing-approach
On start-up, Kibana migrations check the mappings of the Kibana index to determine if there are differing mappings, if so, we re-index the data. When setting `"tree": "quadtree"`, ES is actually representing it in the mapping as `"strategy": "recursive"`. This causes the migrations to always run. These are both defaults for the geo_shape data type, so there shouldn't be any adverse effect here. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
gis-mapping
branch
from
7bf1666
to
e3a51f3
Compare
|
Looks good to me, too. I just wanted to note that this appears to be a more general problem, and could resurface if someone else had a recursive strategy in one of their mappings, and then removed it. Is there a more general fix that would enable migrations to properly handle this for all cases? |
💔 Build Failed |
|
retest |
💔 Build Failed |
|
Merging this - failures are consistent with those on Master from a now reverted PR - just waiting for release-manager to build a new snapshot. |
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Jan 8, 2019
On start-up, Kibana migrations check the mappings of the Kibana index to determine if there are differing mappings, if so, we re-index the data. When setting `"tree": "quadtree"`, ES is actually representing it in the mapping as `"strategy": "recursive"`. This causes the migrations to always run. These are both defaults for the geo_shape data type, so there shouldn't be any adverse effect here. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Jan 8, 2019
On start-up, Kibana migrations check the mappings of the Kibana index to determine if there are differing mappings, if so, we re-index the data. When setting `"tree": "quadtree"`, ES is actually representing it in the mapping as `"strategy": "recursive"`. This causes the migrations to always run. These are both defaults for the geo_shape data type, so there shouldn't be any adverse effect here. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
that referenced
this pull request
Jan 8, 2019
On start-up, Kibana migrations check the mappings of the Kibana index to determine if there are differing mappings, if so, we re-index the data. When setting `"tree": "quadtree"`, ES is actually representing it in the mapping as `"strategy": "recursive"`. This causes the migrations to always run. These are both defaults for the geo_shape data type, so there shouldn't be any adverse effect here. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
|
6.7/6.x: 54414f3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On start-up, Kibana migrations check the mappings of the Kibana index to
determine if there are differing mappings, if so, we re-index the data.
When setting
"tree": "quadtree", ES is actually representing it in the mappingas
"strategy": "recursive". This causes the migrations to always run. Theseare both defaults for the geo_shape data type, so there shouldn't be any adverse
effect here.
It's possible this is an underlying ES issue - I would expect setting this option to be represented in the mapping when it's fetched.
cc @aaronjcaldwell