Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Fix watcher - > watch_edit_execute_detail template #28922

Merged
merged 97 commits into from
Jan 23, 2019

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Jan 17, 2019

Fix watcher -> public -> sections -> watch_edit -> components -> watcher -> watch_edit_execute_detail -> watch_edit_execute_detail.html

Origin PR: #23989

Issue: #28067

Guidline
Readme

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This could be backported all the way to 6.5

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Jan 23, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit f56ed2c into elastic:master Jan 23, 2019
@Nox911 Nox911 deleted the feature/fix-watcher-label_template branch January 23, 2019 14:55
Nox911 added a commit to Nox911/kibana that referenced this pull request Jan 23, 2019
Nox911 added a commit to Nox911/kibana that referenced this pull request Jan 23, 2019
Nox911 added a commit that referenced this pull request Jan 24, 2019
@Nox911
Copy link
Contributor Author

Nox911 commented Jan 24, 2019

6.x/6.7.0: 4ba7b20

Nox911 added a commit that referenced this pull request Jan 24, 2019
@Nox911
Copy link
Contributor Author

Nox911 commented Jan 24, 2019

6.5.5: 6f5c2fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants