[ML] Adding ability to override number of sample lines in File Data Visualizer #29214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
v7.0.0
enhancement
jgowdyelastic
requested review from
walterra,
alvarezmelissa87 and
peteharverson
|
Pinging @elastic/ml-ui |
💔 Build Failed |
|
Code LGTM - I'll give it a play around tomorrow but didn't want to be a blocker 😄 |
| @@ -2,6 +2,28 @@ | |||
|
|
|||
| exports[`Overrides render overrides 1`] = ` | |||
| <EuiForm> | |||
| <EuiFormRow | |||
| describedByIds={Array []} | |||
| error="Value must be greater than 3 and less than or equal to 1000000" | |||
There was a problem hiding this comment.
Isn't it possible to localize this error message?
There was a problem hiding this comment.
in the snapshot file? i don't know?
There was a problem hiding this comment.
Looking in other snapshots, seems only the label is localized, and not error text,
There was a problem hiding this comment.
Doesn't look like it based on already translated snapshot files:
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can now set a custom value between
3and100000for the number of lines thefind_file_structurewill use when analysing the file.Form validation has been added which required refactoring of the overrides component.
Fixes #25458