Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCR] Improve remote clusters test coverage #29487

Merged
merged 10 commits into from
Jan 30, 2019
Merged

[CCR] Improve remote clusters test coverage #29487

merged 10 commits into from
Jan 30, 2019

Commits on Jan 30, 2019

  1. Add Jest test for RemoteClusterForm validation state.

    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    c9445c4 View commit details
    Browse the repository at this point in the history

  2. Extract validation functions out of RemoteClusterForm and add unit te… 

    …sts.
    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    f20d71e View commit details
    Browse the repository at this point in the history

  3. Add unit tests for different types of remote clusters in RemoteCluste… 

    …rTable.
    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    eca8711 View commit details
    Browse the repository at this point in the history

  4. Add unit test for RemoteClusterList empty prompt.

    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    14a2fb1 View commit details
    Browse the repository at this point in the history

  5. Use 'test' syntax instead of 'it'.

    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    7e11ad7 View commit details
    Browse the repository at this point in the history

  6. Add tests verifying behavior for row link, row delete button, and det… 

    …ail panel delete button.

- Use getRouterLinkProps to assign onClick and href to edit buttons in row and detail panel.
    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    c4d0e08 View commit details
    Browse the repository at this point in the history

  7. Convert RemoteClusterList empty state tests from a snapshot to a test… 

    … subject assertion.
    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    0f33488 View commit details
    Browse the repository at this point in the history

  8. Fix i18n key in validateSeed validator.

    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    b9e1c6a View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/feature/ccr' into chore/remote… 

    …-clusters-unit-tests
    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    2687a16 View commit details
    Browse the repository at this point in the history

  10. Code style changes. 

    - Invert negative connotation of variables for improved readability.
- Return null instead of undefined from validators.
- Extract Jest test component instantiation into beforeEach.
    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    4d0bb14 View commit details
    Browse the repository at this point in the history