Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCR] Implement Advanced Settings design feedback #29543

Merged
merged 9 commits into from
Jan 30, 2019
Merged

[CCR] Implement Advanced Settings design feedback #29543

merged 9 commits into from
Jan 30, 2019

Commits on Jan 30, 2019

  1. Use EuiSwitch to toggle advanced settings in Create Follower Index form.

    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    75f3067 View commit details
    Browse the repository at this point in the history

  2. Move 'optional' from each Advanced Setting field to the section heading.

    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    a77511a View commit details
    Browse the repository at this point in the history

  3. Change Advanced Settings switch label and description to emphasize th… 

    …at you can customize them or use the defaults.
    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    5325fa6 View commit details
    Browse the repository at this point in the history

  4. Prepopulate Advanced Settings fields with default values.

    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    b859d4b View commit details
    Browse the repository at this point in the history

  5. When editing a follower index, check if advanced settings have been e… 

    …dited and open them if so.
    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    6c05b6e View commit details
    Browse the repository at this point in the history

  6. Add 'Reset to default' button below advanced settings fields if their… 

    … values are different than the default.
    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    dd191e2 View commit details
    Browse the repository at this point in the history

  7. Remove 'Default' copy from Advanced Settings descriptions.

    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    70bd18e View commit details
    Browse the repository at this point in the history

  8. Remove 'Reset to default' buttons from fields which don't have a defa… 

    …ultValue.
    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    022ea8a View commit details
    Browse the repository at this point in the history

  9. Simplify toggleAdvancedSettings function, add comments, and fix React… 

    … console error.
    @cjcenizal
    cjcenizal committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    433379b View commit details
    Browse the repository at this point in the history