Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Migrate filter bar to React, EUI, and Typescript (#25563)" #29662

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Revert "Migrate filter bar to React, EUI, and Typescript (#25563)" #29662

merged 1 commit into from
Jan 30, 2019

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Jan 30, 2019

This reverts commit 410c094.

@Bargs Bargs requested a review from a team as a code owner January 30, 2019 21:57
@Bargs Bargs merged commit 45b24af into elastic:master Jan 30, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Bargs added a commit to Bargs/kibana that referenced this pull request Jan 31, 2019
@Bargs
Revert "Revert "Migrate filter bar to React, EUI, and Typescript (ela…
a909d86 
…stic#25563)" (elastic#29662)"

This reverts commit 45b24af.
@Bargs Bargs mentioned this pull request Jan 31, 2019
Merged
Bargs added a commit that referenced this pull request Jan 31, 2019
@Bargs
Re-introduce new filter bar (#29752)
8a83955 
Fixes the build issues introduced in #25563 and re-introduces the new react/eui/typescript filter bar, essentially reverting the revert in #29662. I did have to resolve one merge conflict in query_bar.tsx, and re-deleted all of the old filter bar code where translation code had been added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bargs @elasticmachine