Fix legend overflow bug on dashboard vis #29948
Conversation
flash1293
added
bug
|
Pinging @elastic/kibana-app |
|
Jenkins, test this |
1 similar comment
|
Jenkins, test this |
💔 Build Failed |
|
Was there a particular chart this was broken on? This is what I see in master: |
💔 Build Failed |
|
@cchaos apparently seems that this bug is present only on firefox. I've tested current master on the following cases:
|
There was a problem hiding this comment.
Code LGTM.
I've tested it with a barchart on logstash demo data:
- X axis date histogram with @timestamp field
- split series: terms by
geo.srcdest
Tested and works fine on the following:
Chrome on OSX: ✅
Safari on OSX: ✅
Firefox on OSX: ✅
IE11 on Windows : ✅
Firefox on Windows: ✅
|
Ok, I'm seeing the issue on Firefox, but while this fix fixes dashboards, it breaks the vis editor:
|
|
Good catch @cchaos , working on it |
This reverts commit 3f012c8.
…e vis editor layouting
flash1293
force-pushed
the
fix/22597-scss-styles-missing
branch
from
9804fa4
to
4fc5628
Compare
|
The most recent commit seems to work for me on (Mac) Chrome, Firefox and IE11. Thx |
💚 Build Succeeded |
|
@markov00 Since the CSS was changed again, do you think you could revalidate it quickly? |
|
Going to merge this as discussed offline with @timroes |
Summary
Fixes #22597
This fixes the legend overflow problem described in #23806
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately