Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing position of job management search bar error #30251

Merged
merged 3 commits into from Feb 7, 2019
Merged

[ML] Fixing position of job management search bar error #30251

merged 3 commits into from Feb 7, 2019

Conversation

jgowdyelastic
Copy link
Member

When entering invalid text into the search bar, then error is displayed in a callout which throws off the layout of the page, especially if the multi-select menu is visible.
This changes the error to be a normal eui form validation error.

Before:
image

After:
image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@jgowdyelastic jgowdyelastic self-assigned this Feb 6, 2019
@jgowdyelastic jgowdyelastic requested review from a team as code owners February 6, 2019 15:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@jgowdyelastic jgowdyelastic changed the title [ML] Fixing position of job management search bar style error [ML] Fixing position of job management search bar error Feb 6, 2019
alvarezmelissa87
alvarezmelissa87 approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

walterra
walterra approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

snide
snide approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@snide snide left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sass in here looks fine. If you all had some time, I'd recommend using a less custom pattern for this interaction. Doesn't need to be this PR obviously. Using a more generic way to do it prevents small breaks like this generally.

peteharverson
peteharverson approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest change LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit ee6135f into elastic:master Feb 7, 2019
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 7, 2019
@jgowdyelastic
[ML] Fixing position of job management search bar error (elastic#30251)
8225009 
* [ML] Style tweaks for job management in K7

* adjusting search bar error

* removing custom title style for EuiTitle
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 7, 2019
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 7, 2019
@jgowdyelastic
[ML] Fixing position of job management search bar error (elastic#30251)
2fbb49f 
* [ML] Style tweaks for job management in K7

* adjusting search bar error

* removing custom title style for EuiTitle
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 7, 2019
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 7, 2019
@jgowdyelastic
[ML] Fixing position of job management search bar error (elastic#30251)
d2eb65e 
* [ML] Style tweaks for job management in K7

* adjusting search bar error

* removing custom title style for EuiTitle
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 7, 2019
Merged
jgowdyelastic added a commit that referenced this pull request Feb 7, 2019
@jgowdyelastic
[ML] Fixing position of job management search bar error (#30251) (#30359
e38fcbc 
)

* [ML] Style tweaks for job management in K7

* adjusting search bar error

* removing custom title style for EuiTitle
jgowdyelastic added a commit that referenced this pull request Feb 7, 2019
@jgowdyelastic
[ML] Fixing position of job management search bar error (#30251) (#30360
773f631 
)

* [ML] Style tweaks for job management in K7

* adjusting search bar error

* removing custom title style for EuiTitle
jgowdyelastic added a commit that referenced this pull request Feb 7, 2019
@jgowdyelastic
[ML] Fixing position of job management search bar error (#30251) (#30361
252a099 
)

* [ML] Style tweaks for job management in K7

* adjusting search bar error

* removing custom title style for EuiTitle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@snide snide snide approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:Anomaly Detection ML anomaly detection :ml review v6.7.0 v7.0.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jgowdyelastic @elasticmachine @walterra @snide @alvarezmelissa87 @peteharverson