Remove id attribute from canvas attributes #30736
Conversation
mikecote
changed the title
|
Jenkins, test this |
💚 Build Succeeded |
|
Jenkins, test this |
mikecote
added
Team:Presentation
|
Pinging @elastic/kibana-canvas |
💔 Build Failed |
💚 Build Succeeded |
|
@mikecote actually, one small thing for you to add to this PR. All the sample workpads still have an id property on the workpad, and those need to be removed as well. See the JSON files in x-pack/plugins/canvas/server/sample_data |
| @@ -4,10 +4,11 @@ | |||
| "type": "canvas-workpad", | |||
| "updated_at": "2018-10-22T15:19:02.081Z", | |||
| "version": 1, | |||
| "migrationVersion": {}, | |||
| "migrationVersion": { | |||
There was a problem hiding this comment.
Since I don't know what this is used for, I might as well ask... what is this used for?
There was a problem hiding this comment.
This is to indicate to the migrator what version the data is migrated up to. Having {} indicates that the system needs to run all the canvas-workpad migrations when creating the record. Having 7.0.0 value here indicates to the migrator that the record is migrated up to version 7.0.0.
In this scenario the migrator won't need to run any migrations since the id field is already removed.
There was a problem hiding this comment.
Ah, but it allows us to have, for example, an 8.0.0 migration in the future, and it would only run that since it knows it's already on 7.0.0. That's neat, thanks for the explanation!
💔 Build Failed |
💔 Build Failed |
|
Sorry, you'll need to merge master to get rid of those OOM errors |
💚 Build Succeeded |
* Remove id attribute from canvas attributes * Fix create and update API * Add migration tests * Use constants * Add API tests * Cleanup tests * Apply PR feedback
* Remove id attribute from canvas attributes * Fix create and update API * Add migration tests * Use constants * Add API tests * Cleanup tests * Apply PR feedback
This PR removes the
idattribute from canvas mappings and uses the rootidattribute from saved objects (solves canvas portion of #30455). The reason ids need to be removed fromattributesis to facilitate new import / export feature (development in progress) that may change the ids when conflicts exist. See #27203.