Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce workaround for vega height bug #31461

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Introduce workaround for vega height bug #31461

merged 2 commits into from
Feb 25, 2019

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Feb 19, 2019 •
edited
Loading

Summary

Fixes #25855

This is a workaround which hopefully becomes obsolete with vega 5 (currently upgrading doesn't work because of #31413

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@flash1293 flash1293 changed the title [wip] Introduce workaround for vega height bug Introduce workaround for vega height bug Feb 19, 2019
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

nyurik
nyurik approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this change, but is there a way to unit test this behavior? It would make it easier to remove this hack at a later date.

@flash1293
Copy link
Contributor Author

@nyurik Done! It seems like this bug is triggered by very specific circumstances. For instance it didn't trigger if the font-size in the sample spec is smaller than 14px (maybe has sth. to do with the total height? No idea...)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

timroes
timroes approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that it fixes the behavior. While testing figured out, that vega is really buggy with handling those signals in general. Hopefully something that will be fixed in future versions.

@nyurik
Copy link
Contributor

nyurik commented Feb 21, 2019

Tested that it fixes the behavior. While testing figured out, that vega is really buggy with handling those signals in general. Hopefully something that will be fixed in future versions.

@timroes anything specific that Vega team can act on? They have been making amazing progress in code quality improvements - merged it into a monorepo, began using async/await, etc. It would be great if we can help them in this "never ending quest for quality and performance" :)

@flash1293
Copy link
Contributor Author

Waiting for #31693 before merging this

@flash1293
Copy link
Contributor Author

Tested the backported fix on 7.0, works also in IE

@flash1293 flash1293 merged commit de0345a into elastic:master Feb 25, 2019
@flash1293 flash1293 deleted the 25855/fix-vega-height-bug branch February 25, 2019 20:18
flash1293 added a commit to flash1293/kibana that referenced this pull request Feb 25, 2019
@flash1293
Introduce workaround for vega height bug (elastic#31461)
c3b25ee
@flash1293 flash1293 mentioned this pull request Feb 25, 2019
Merged
flash1293 added a commit to flash1293/kibana that referenced this pull request Feb 25, 2019
@flash1293
Introduce workaround for vega height bug (elastic#31461)
b2816d7
@flash1293 flash1293 mentioned this pull request Feb 25, 2019
Merged
flash1293 added a commit to flash1293/kibana that referenced this pull request Feb 25, 2019
@flash1293
Introduce workaround for vega height bug (elastic#31461)
fdafa16
@flash1293 flash1293 mentioned this pull request Feb 25, 2019
Merged
flash1293 added a commit that referenced this pull request Feb 26, 2019
@flash1293
Introduce workaround for vega height bug (#31461) (#31955)
8125f04
flash1293 added a commit that referenced this pull request Feb 26, 2019
@flash1293
Introduce workaround for vega height bug (#31461) (#31954)
6140e4c
flash1293 added a commit that referenced this pull request Feb 26, 2019
@flash1293
Introduce workaround for vega height bug (#31461) (#31953)
071cbda
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jul 22, 2020
@alexwizp
remove workaround for vega height bug
bd26897 
Related to elastic#31461
@alexwizp alexwizp mentioned this pull request Jul 22, 2020
Merged
7 tasks
alexwizp added a commit that referenced this pull request Jul 23, 2020
@alexwizp @elasticmachine
Failing test: Jest Tests.src/plugins/vis_type_vega/public (#71834)
b2a473d 
* Failing test: Jest Tests.src/plugins/vis_type_vega/public

* remove workaround for vega height bug

Related to #31461

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jul 23, 2020
@alexwizp @elasticmachine
Failing test: Jest Tests.src/plugins/vis_type_vega/public (elastic#71834
fbb408e 
)

* Failing test: Jest Tests.src/plugins/vis_type_vega/public

* remove workaround for vega height bug

Related to elastic#31461

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp added a commit that referenced this pull request Jul 23, 2020
@alexwizp @elasticmachine
Failing test: Jest Tests.src/plugins/vis_type_vega/public (#71834) (#…
65c97e4 
…73015)

* Failing test: Jest Tests.src/plugins/vis_type_vega/public

* remove workaround for vega height bug

Related to #31461

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@nyurik nyurik nyurik approved these changes

Assignees
No one assigned
Labels
release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.7.0 v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flash1293 @elasticmachine @nyurik @timroes