Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble chart #3154

Merged
merged 44 commits into from Mar 17, 2015
Merged

Bubble chart #3154

merged 44 commits into from Mar 17, 2015

Conversation

panda01
Copy link
Contributor

@panda01 panda01 commented Feb 24, 2015

Made the Line Chart convertible into a bubble chart.

Added a z aspect to the point series.
Modified the tooltip that shows up on hover to show multiple metrics.
Added adjustable Point radius to the LineChart.
Added a flag that turns off and on the lines connecting points.
Added a an adjuster for the Ratio of the smallest circle to the largest.
Modified the editor aggregations to respect the minimum attr on Agg Schemas.
Modified some tests to accommodate aforementioned changes.

Closes #2914.

@panda01 panda01 added this to the 4.1.0 milestone Feb 24, 2015
@rashidkpc rashidkpc removed the v4.1.0 label Feb 25, 2015
@panda01 panda01 added the review label Feb 25, 2015
@panda01 panda01 assigned panda01 and lukasolson and unassigned panda01 Feb 25, 2015
@lukasolson
Copy link
Member

I'm not really sure how this should function, but I'm seeing some strange behavior when you start messing around with the number of y-axis aggregations.

If you add a dot size aggregation, then remove the y-axis aggregation, it doesn't seem to have an effect. The y-axis aggregation still shows up as if you hadn't removed it. (Again, I'm not sure was I'd expect to see with a dot size aggregation with no y-axis aggregation.)

no-y-axis

If you have multiple y-axis aggregations, and then add a dot size aggregation, it seems as though the dot sizes no longer are affected. It's as if you had no dot size aggregation at all. (I don't know what to do in this situation either... should the dot sizes vary on both of the y-axis lines?...)

two-y-axes

Might be worth asking some of the other guys. @jthomassie? @stormpython? @rashidkpc?

@lukasolson lukasolson assigned panda01 and unassigned lukasolson Feb 26, 2015
@lukasolson lukasolson removed the review label Feb 26, 2015
@rashidkpc
Copy link
Contributor

We should also get the result of the dot size agg into the tooltip. Currently only has the y-axis metric in there.
image

@simianhacker
Copy link
Member

Aggregations

We should remove standard deviation and percentiles metrics aggs from the dot metric. It doesn't make sense since the dots don't support multiple metric aggs.

Bubble Size

Is there a way to increase the max and min bubble size? Or make it configurable?

image

Much Colors, So Pretty

image

@simianhacker
Copy link
Member

Rolling over the legend only highlights and fades the lines not the dots

bubble-legend-rollover

But it does for the lines (It probably never did the dots but it sure would be nice if it did :D)

bubble-line-rollover

@jthomassie
Copy link

PR #3227 adds highlighting and unhighlighting of the lines, circles and pie
slices on hover and mouseout of the legend (for line, area, column and pie)

On Mon, Mar 2, 2015 at 7:48 PM, Chris Cowan notifications@github.com
wrote:

Rolling over the legend only highlights and fades the lines not the dots

[image: bubble-legend-rollover]
https://cloud.githubusercontent.com/assets/41702/6455046/8afc6d7a-c10c-11e4-9870-c2f1fed51ae8.gif

But it does for the lines (It probably never did the dots but it sure
would be nice if it did :D)

[image: bubble-line-rollover]
https://cloud.githubusercontent.com/assets/41702/6455053/a0b8f2be-c10c-11e4-98f6-3054f94f3bd2.gif


Reply to this email directly or view it on GitHub
#3154 (comment).

Juan Thomassie
Elasticsearch
m) 703.470.5793
juan.thomassie@elasticsearch.com

@lukasolson lukasolson removed the review label Mar 3, 2015
@lukasolson lukasolson removed their assignment Mar 3, 2015
…e standard deviation and percentiles filter is removed from the Point Size metric
… the ratio and scale of the chart

[Forms/validation] Added a directive that simply doesn't show errors until the user has actually made a mistake

[VisualizeSidebar, CreateIndexForm] Added the inTimeErrors Directive to the Visualize Sidebar and create index form

Revert "[VisualizeSidebar, CreateIndexForm] Added the inTimeErrors Directive to the Visualize Sidebar and create index form"

This reverts commit 513d355.

Revert "[Forms/validation] Added a directive that simply doesn't show errors until the user has actually made a mistake"

This reverts commit fb6fc07.
… added back the adjustable point radius removed due to merge
…es aren't being drawn between points on the bubbleChart
Conflicts:
	src/kibana/components/vislib/visualizations/line_chart.js
	src/kibana/plugins/vis_types/vislib/editors/line.html
	src/kibana/plugins/vis_types/vislib/line.js
	src/kibana/plugins/visualize/editor/agg.html
spalger added a commit that referenced this pull request Mar 17, 2015
@spalger spalger merged commit d4cacb9 into elastic:master Mar 17, 2015
@spalger
Copy link
Contributor

spalger commented Mar 17, 2015

Good work @panda01! Excited to finally have this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bubble charts
6 participants