Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Make markdown across Kibana consistent #31890

Merged
merged 1 commit into from Feb 25, 2019
Merged

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Feb 25, 2019

Summary

Fix: #14436. GFMD (GitHub Flavored Markdown Spec) checked

Release Summary: TSVB now uses the same markdown parser than the Markdown visualization.

Before:
before_1

After:
after_1

Checklist

For maintainers

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally and now it display nicely!
Please can you change the title of this PR to include TSVB? We still have some components that use a different markdown implementation MarkdownSimple and I think it's better keep that title when we will finally have a single implementation across kibana :)

@alexwizp alexwizp changed the title Make markdown across Kibana consistent [TSVB] Make markdown across Kibana consistent Feb 25, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants